This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat: support reanimated v3 #14
Draft
+10,213
−11,925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alantoa, are you still working on this? Need a hand with this? |
bkensey
reviewed
Aug 16, 2023
| @@ -546,16 +547,16 @@ const VideoPlayer = forwardRef<VideoPlayerRef, VideoProps>( | |||
| } | |||
| if (x < leftDoubleTapBoundary) { | |||
| doubleLeftOpacity.value = 1; | |||
| rippleLeft.current?.onPress({ x, y }); | |||
| // rippleLeft.current?.onPress({ x, y }); | |||
| runOnJS(seekByStep)(true); | |||
There was a problem hiding this comment.
I'm trying to do some work to figure this out too and this line and the corresponding rippleRight call at line 556 is the issue. We clearly aren't doing any actual assignment here, but we are assigning an onPress function in ripple.tsx on line 61 via useImperativeHandle. I think something here is getting read as an assignment to the (non mutable) refObjects that that the ripple refs are created as. Working on trying to understand what could be going on here. My intuition is that this is less of a react-native-reanimated issue and more of a react/typescript issue. Any thoughts?
|
Would love to know what's left to do here 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.