Fix <a> without href stripping html (microsoft#152230)

Fixes microsoft#152170
alanrenmsft · Jun 15, 2022 · 57037a7 · 57037a7
1 parent 98ad4c1
commit 57037a7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/vs/base/browser/markdownRenderer.ts b/src/vs/base/browser/markdownRenderer.ts
@@ -265,7 +265,7 @@ export function renderMarkdown(markdown: IMarkdownString, options: MarkdownRende
 				|| /^command:(\/\/\/)?_workbench\.downloadResource/i.test(href)
 			) {
 				// drop the link
-				a.replaceWith(a.textContent ?? '');
+				a.replaceWith(...a.childNodes);
 			} else {
 				let resolvedHref = _href(href, false);
 				if (markdown.baseUri) {

diff --git a/src/vs/base/test/browser/markdownRenderer.test.ts b/src/vs/base/test/browser/markdownRenderer.test.ts
@@ -173,6 +173,14 @@ suite('MarkdownRenderer', () => {
 </tbody></table>
 `);
 		});
+
+		test('render icon in <a> without href (#152170)', () => {
+			const mds = new MarkdownString(undefined, { supportThemeIcons: true, supportHtml: true });
+			mds.appendMarkdown(`<a>$(sync)</a>`);
+
+			const result: HTMLElement = renderMarkdown(mds).element;
+			assert.strictEqual(result.innerHTML, `<p><span class="codicon codicon-sync"></span></p>`);
+		});
 	});
 
 	suite('ThemeIcons Support Off', () => {