7098.m.clangtidy #20
Closed
7098.m.clangtidy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
force-pushed
the
7098.m.clangtidy
branch
2 times, most recently
from
b6eefa4
to
331ef9b
Compare
The pam_password authentication plugin has 2 problems:
1. PAM passwords cannot exceed 50 characters.
2. The password_length configuration of the pam_password authentication
plugin_configuration has no effect.
This change removes the static buffer for holding the password which is
then sent to the server via the authenticate API. The password is now
stored in full in the JSON payload.
The password_length configuration which was previously used to govern
the size of the randomly generated password for users authenticating
with pam_password has been removed. The randomly generated password will
now be a static length of 50 characters.
The PAM password itself will not be limited in any way by iRODS and will
simply be passed along to the PAM service for authentication.
Finally, the randomly generated password for PAM authentication users
can now have an apostrophe when in scrambled form. This was prevented in
the past for compatibility with platforms for which this presented a
problem. Apostrophes are inserted into the catalog for many parts of
iRODS, so this effort is no longer necessary.
alanking
force-pushed
the
7098.m.clangtidy
branch
from
a996f57
to
72d1681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.