Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 v3.0.0 #16

Merged
merged 11 commits into from
Jun 23, 2024
Merged

🔖 v3.0.0 #16

merged 11 commits into from
Jun 23, 2024

Conversation

alankan886
Copy link
Owner

@alankan886 alankan886 commented Jun 23, 2024

Basically rewrote the code a little bit. Took out the class structure that it used to have, it was basically unnecessary, I think I was just a junior engineer that wanted to be fancy and use new packages like attrs (very cool package though).

I decided to refactor with a mindset of simplicity for users, the usage really is just reviewing a new card, put those values into database, pull those values from database and review that card again using previous values. I feel like people really just want a dictionary with those values so they can easily put it into database, and when they pull those values from database, they can easily plug it into the SM2 function.

Also, I decided to make the review_date into datetime, so it's more specific for users on when to review, and also default to using UTC timezone instead of local timezone, I think that makes a lot more sense.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (80affaf) to head (dab7cc3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           43        27   -16     
=========================================
- Hits            43        27   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alankan886 alankan886 marked this pull request as ready for review June 23, 2024 02:38
@alankan886 alankan886 merged commit 6de5b77 into main Jun 23, 2024
18 checks passed
@alankan886 alankan886 deleted the v3.0.0 branch June 23, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant