Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove most occurences of strcpy/strcat #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jul 5, 2013

  1. remove most occurences of strcpy/strcat

    those functions are insecure and in the case of strcat even slow,
    since the strlen has to be checked on each call.
    they are considered a code-smell; instead, snprintf should be used.
    
    snprintf(buf, sizeof buf, "%s", mystring) is the only way offered
    by C99 to do a bounds-checked copy of a string (and after parsing
    the format string (which should only take a handful of cycles),
    performance is identical to a naive strcpy implementation using
    a for loop until 0 is hit).
    
    note that strncpy() always fills the entire buffer, so it is a
    performance hog.
    rofl0r committed Jul 5, 2013
    Configuration menu
    Copy the full SHA
    db0a358 View commit details
    Browse the repository at this point in the history