Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CI for template instantiation #24

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Jacob-Stevens-Haas
Copy link
Contributor

This PR adds CI to create an instance of the template and run pre-commits on it. Hopefully this can help with #14

I believe this counts as fixing #4, depending on what you want to see in the CI.

@Jacob-Stevens-Haas
Copy link
Contributor Author

I'm not sure why the PR didn't trigger the action in the PR, but it might need to be approved by repo owners, or add me as a collaborator?

@phinate
Copy link
Collaborator

phinate commented Feb 12, 2024

Many thanks for doing this! It's a great start: I'd be keen to set up a matrix to run over python versions and different backends/config options too.

I'm not sure why the PR didn't trigger the action in the PR, but it might need to be approved by repo owners, or add me as a collaborator?

Huh. Never ran into this before. Can you confirm it runs locally with https://github.com/nektos/act just to make sure the YAML is GitHub-valid?

@Jacob-Stevens-Haas
Copy link
Contributor Author

I think I have run into this before, let me see if I can look up why

@Jacob-Stevens-Haas
Copy link
Contributor Author

Jacob-Stevens-Haas commented Feb 13, 2024

Couldn't build act and most recent release binary didn't work, but did find this nugget in github actions docs:

Some events also require the workflow file to be present on the default branch of the repository in order to run.

It may need to be merged to be tested.

FWIW, you may also want to run CI on pushes to master, since master branch isn't protected.

Copy link
Collaborator

@phinate phinate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test on main!

@phinate phinate merged commit 42a0b88 into alan-turing-institute:main Feb 21, 2024
1 check failed
@Jacob-Stevens-Haas
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants