Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change saving to pathlib #204

Merged
merged 1 commit into from
Mar 12, 2024
Merged

change saving to pathlib #204

merged 1 commit into from
Mar 12, 2024

Conversation

mastoffel
Copy link
Collaborator

saving models now with pathlib and a bit more robust.

add tests

fix save_models
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  save.py 63-65, 104
  tests
  test_save.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.61%. Comparing base (aa81a13) to head (a1764a6).
Report is 5 commits behind head on main.

Files Patch % Lines
autoemulate/save.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   90.68%   90.61%   -0.07%     
==========================================
  Files          45       45              
  Lines        2264     2269       +5     
==========================================
+ Hits         2053     2056       +3     
- Misses        211      213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastoffel mastoffel merged commit b512fe3 into main Mar 12, 2024
6 checks passed
@mastoffel mastoffel deleted the improve-saving branch March 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants