-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve open-source contribution infrastructure #156
Conversation
@mastoffel This is just to resolve the last few comments from #71 where we had discussed plugging this information in from the related issues in comments. I have also connected up the code of conduct and the contributions guide to the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a minor comment, then happy to merge!
CONTRIBUTING.md
Outdated
We welcome contributions of all kinds, be it code, documentation, or community engagement. We encourage you to read through the following sections to learn more about how you can contribute to | ||
We welcome contributions of all kinds, be it code, documentation, or community engagement. We encourage you to read through the following sections to learn more about how you can contribute to the package. | ||
|
||
We are always interested in adding more sampling/experimental design strategies (see https://github.com/alan-turing-institute/autoemulate/issues/6) and more simulation data packages (see https://github.com/alan-turing-institute/autoemulate/issues/4). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can take out the first bit about design strategies. Most sampling/experimental design strategies are implemented already in some software, so we just need to chose a few more.
But it'd be great to have more simulations, or simulation input/output datasets from any field, let's maybe focus this on the second part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See ebaa98a
Ready for merge @mastoffel ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 40 40
Lines 1788 1789 +1
=======================================
+ Hits 1638 1639 +1
Misses 150 150 ☔ View full report in Codecov by Sentry. |
Fixes #71