Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve open-source contribution infrastructure #156

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

kallewesterling
Copy link
Collaborator

Fixes #71

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@kallewesterling
Copy link
Collaborator Author

@mastoffel This is just to resolve the last few comments from #71 where we had discussed plugging this information in from the related issues in comments. I have also connected up the code of conduct and the contributions guide to the documentation.

Copy link
Collaborator

@mastoffel mastoffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a minor comment, then happy to merge!

CONTRIBUTING.md Outdated
We welcome contributions of all kinds, be it code, documentation, or community engagement. We encourage you to read through the following sections to learn more about how you can contribute to
We welcome contributions of all kinds, be it code, documentation, or community engagement. We encourage you to read through the following sections to learn more about how you can contribute to the package.

We are always interested in adding more sampling/experimental design strategies (see https://github.com/alan-turing-institute/autoemulate/issues/6) and more simulation data packages (see https://github.com/alan-turing-institute/autoemulate/issues/4).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can take out the first bit about design strategies. Most sampling/experimental design strategies are implemented already in some software, so we just need to chose a few more.

But it'd be great to have more simulations, or simulation input/output datasets from any field, let's maybe focus this on the second part.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ebaa98a

@kallewesterling
Copy link
Collaborator Author

Ready for merge @mastoffel !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0139be9) 91.61% compared to head (ebaa98a) 91.61%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          40       40           
  Lines        1788     1789    +1     
=======================================
+ Hits         1638     1639    +1     
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kallewesterling kallewesterling merged commit 3a59bb2 into main Feb 12, 2024
6 checks passed
@kallewesterling kallewesterling deleted the kallewesterling/issue71 branch February 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[epic] Improve open-source contribution infrastructure
3 participants