Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test set split #155

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Test set split #155

merged 9 commits into from
Feb 12, 2024

Conversation

mastoffel
Copy link
Collaborator

@mastoffel mastoffel commented Feb 12, 2024

  • validate on test set when hyperparameter tuning, but keeping cross-validation when comparing models using defaults.

resolves #118

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  compare.py 210, 310
  cross_validate.py
  plotting.py
  printing.py 31-33, 40-42
  utils.py
  tests
  test_cross_validate.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a70aa6e) 91.54% compared to head (c36ecc8) 91.61%.

Files Patch % Lines
autoemulate/printing.py 62.50% 6 Missing ⚠️
autoemulate/compare.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   91.54%   91.61%   +0.06%     
==========================================
  Files          40       40              
  Lines        1739     1788      +49     
==========================================
+ Hits         1592     1638      +46     
- Misses        147      150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastoffel mastoffel merged commit 0139be9 into main Feb 12, 2024
6 checks passed
@mastoffel mastoffel deleted the test-set-split branch February 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate with held-out set after hyperparameter search
2 participants