-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create one tutorial/example notebook #153
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
add text to 01_start notebook add text to tutorial add text to tutorial let save_model take a model add tutorial updates fix demos problem with jupyter book
@kallewesterling I'm still having the issue that the logs are rendered in different boxes rather than all together. I've merged you're previous PR but |
Also just to summarise:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 91.62% 91.51% -0.11%
==========================================
Files 40 40
Lines 1790 1792 +2
==========================================
Hits 1640 1640
- Misses 150 152 +2 ☔ View full report in Codecov by Sentry. |
Pulling in latest edits to docs (and Bryan's latest update)
@mastoffel Should we open this as a real PR? |
@kallewesterling yes, I think so. I'm currently working on another PR which will change the tutorials slightly, so will do that first and then give the tutorials an overhaul. |
add tests for new cv_run output run both param search and cv on training data fix print for new param search setup fix plotting for new param search setup let compare return best_model add model test score add test_score test small fixes
A few more changes, mainly:
There are a few more changes in here (which should have probably been in another PR), but nothing big. |
Thanks @mastoffel -- I'll try to have a look at this today so we can get this PR approved before the end of the sprint! |
LGTM for quickstart and 01_start.ipynb |
@kallewesterling did you have a chance to look at the tutorials? If not, I think it should be ok to merge. They'll get a re-write anyway soon. |
I haven't had a chance, no, sorry. Quite pressed for time currently and will need to adjust the expectations in the next sprint. I'm happy with incremental dev on these things though! Feel free to merge. |
I am creating a draft PR here so it's easier to have a conversation about what this looks like.