Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve red background on notebook outputs in documentation #152

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kallewesterling
Copy link
Collaborator

Fixes #151

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  logging_config.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc7a180) 91.72% compared to head (30c915a) 91.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          36       36           
  Lines        1691     1692    +1     
=======================================
+ Hits         1551     1552    +1     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastoffel
Copy link
Collaborator

@kallewesterling could you give a bit of detail here? When do you see a red background on notebook outputs? Is ch = logging.StreamHandler(sys.stdout) the fix?

@kallewesterling
Copy link
Collaborator Author

Yes, sorry! So when the example notebook below (in the image) would render the outputs, they would look like warnings, but a quick googling showed that this solves it. It's a quirk with JupyterBook I think.

image

@kallewesterling kallewesterling marked this pull request as ready for review February 9, 2024 16:15
@kallewesterling
Copy link
Collaborator Author

@mastoffel would you be able to approve this before our demo meeting, you think?

@mastoffel
Copy link
Collaborator

@kallewesterling yes of course, sorry! Happy to merge.

@kallewesterling kallewesterling merged commit 980ef19 into main Feb 12, 2024
6 checks passed
@kallewesterling kallewesterling deleted the kallewesterling/issue151 branch February 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve red background on notebook outputs in documentation
3 participants