Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure home page #626

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Restructure home page #626

merged 3 commits into from
Oct 10, 2023

Conversation

llewelld
Copy link
Collaborator

@llewelld llewelld commented Oct 4, 2023

Updates te homepage layout and content following user testing and so that all of the elements work correctk (e.g. links to other parts of the site).

Contributes to #586.

@llewelld llewelld self-assigned this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Coverage report

The coverage rate went from 98.78% to 98.86% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

server/apps/main/helpers.py

100% of new lines are covered (99.67% of the complete file).

server/apps/main/tests/test_helpers.py

100% of new lines are covered (100% of the complete file).

server/apps/main/tests/test_views.py

100% of new lines are covered (99.09% of the complete file).

server/apps/main/views.py

100% of new lines are covered (97.64% of the complete file).

@llewelld llewelld force-pushed the iss586_front_page branch 2 times, most recently from fe2fa84 to a02b58c Compare October 5, 2023 16:20
@llewelld
Copy link
Collaborator Author

llewelld commented Oct 5, 2023

This should be ready so I'm removing the draft tag.

The implementation is suboptimal: the uuids for real stories should go in the database rather than the carousels.json file. But it felt like there were probably more pressing things to work on, so I've created task #627 to fix this.

@llewelld llewelld marked this pull request as ready for review October 5, 2023 16:29
@llewelld
Copy link
Collaborator Author

llewelld commented Oct 5, 2023 •
edited
Loading

Fixes #586.

@llewelld llewelld linked an issue Oct 5, 2023 that may be closed by this pull request
User Testing: Update front page #586
Closed
9 tasks
gedankenstuecke
gedankenstuecke reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@gedankenstuecke gedankenstuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @llewelld! Barring one bug and one typo I think these are now mostly comments that are open for discussion whether to do any changes on these or not!

server/apps/main/views.py Outdated Show resolved Hide resolved
server/apps/main/templates/main/home.html Outdated Show resolved Hide resolved
server/apps/main/templates/main/home.html
<div class="col-lg-12 platform-title">
<h2 class="section-heading">How to Use The Platform</h2>
<div class="col-lg-12 platform-title">
<h2 class="section-heading">How to use the platform</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember on top-of-my-head what the user testing results where on this, but I do feel like we can potentially reorder and simplify this bit? I'd say the order

  1. View
  2. (Learn)
  3. Register
  4. Share

could be an easier one, I don't think the edit necessarily needs to appear, and even the "learn" could go into "view"?

Tagging @GeorgiaHCA in case she has a suggestion!

server/apps/main/templates/main/home.html Outdated Show resolved Hide resolved
gedankenstuecke
gedankenstuecke approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@gedankenstuecke gedankenstuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd be happy to have that merged in and then we can discuss additional changes to the front page outside this PR to not have the perfect be the enemy of the good!

@llewelld
Restructure home page
de7ffdd 
Updates te homepage layout and content following user testing and so
that all of the elements work correctk (e.g. links to other parts of the
site).

Contributes to alan-turing-institute#586.
@llewelld
Update footer links
ebd5876 
Adds links to the items in the footer. Some of these are placeholders,
with the idea that they help direct people to where they can contribute.
@llewelld
Add carousel selector
2c6b957 
Adds a carousel.json file that contains dummy stories for the carousel.
A list of uuids to real stories can also be added to the file. The real
stories are chosen in preference to the dummy stories as long as:

1. The real stories have been moderated and approved.
2. The real stories have no trigger labels.
@llewelld llewelld merged commit 14b9e67 into alan-turing-institute:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedankenstuecke gedankenstuecke gedankenstuecke approved these changes

@helendduncan helendduncan Awaiting requested review from helendduncan

Assignees

@llewelld llewelld

Labels
None yet
Projects
None yet
Milestone
3: Improve MVP based on user testing
Development

Successfully merging this pull request may close these issues.

User Testing: Update front page
2 participants
@llewelld @gedankenstuecke