Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kcl/extract plugin requirements #24

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alacuku
Copy link
Owner

@alacuku alacuku commented Mar 18, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@alacuku alacuku force-pushed the kcl/extract-plugin-requirements branch 10 times, most recently from 6c9e1fa to b4fe219 Compare March 19, 2024 13:14
When no requirements are provided by cli flags, the push
command will try to get them from the plugins. Plugins are
provided as shared objects, so falcoctl will load them if
are built for the same platform such the one where falcoctl
is running. When no requirements are provided and falcoctl
is not able to parse them from the plugin then it logs a
warning message and continues.

Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku alacuku force-pushed the kcl/extract-plugin-requirements branch from b4fe219 to 012b0d7 Compare March 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant