Properly aligning the alacritty logo on the top #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logo and the text weren't on the same line. alacritty#1 has more info
chrisduerr
requested changes
Aug 4, 2021
There was a problem hiding this comment.
This doesn't actually work out well at all when it comes to my font:
I assume that's the case for most fonts and I don't think there's any good solution to alignment of images to arbitrary fonts. Something I've considered during creation already though is to just transform everything into a single image, I think that's realistically the only way this could every look properly on all systems.
|
Can't we just make the font constant. Is that possible? Single image solution is workable too I guess. |
No. |
|
Closing because dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logo and the text weren't on the same line.
#1 has more info