Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added escaping for \n and \r #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aydinaghali
Copy link

No description provided.

@al-eax
Copy link
Owner

al-eax commented Jun 3, 2024

hi @aydinaghali thanks for your PR :)
can you please apply camel case style to your variables?
new_line --> newLine
https://en.wikipedia.org/wiki/Camel_case

@al-eax
Copy link
Owner

al-eax commented Jun 3, 2024

@aydinaghali one last thing:
CSV does not always use line breaks to indicate a new row. In some cases, CSV readers use a fixed number of columns to split the dataset, so escaping is not required.

Escaping new lines in strings should be optional (like the seperator field) and (maybe?) disabled by default.

Could you also enrich the README?
Thank you so much for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants