Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reordering handlers #186

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

damikdk
Copy link
Contributor

@damikdk damikdk commented Sep 10, 2018

Hi, I added handlers for reorder events, so now we can use reorderable TableView inside ScrollView!

P.S. Month passed from my previous PR, it would be great if you test and approve it too :)

@iRoachie iRoachie changed the base branch from master to next September 28, 2018 04:31
@iRoachie
Copy link
Collaborator

Merged your other PR, could you add to the example app? Also can you update the typescript definitions to add these new methods?

@iRoachie iRoachie changed the base branch from next to master September 28, 2018 04:52
@iRoachie iRoachie changed the base branch from master to next September 28, 2018 04:53
@damikdk
Copy link
Contributor Author

damikdk commented Sep 28, 2018

Done!

Btw, can you check my English in readme file? I'm not native speaker, so I'm not sure about my instructions.

@damikdk
Copy link
Contributor Author

damikdk commented Oct 12, 2018

Any update here?

@iRoachie
Copy link
Collaborator

Hey @damikdk will review this week, was on vacation!

@damikdk
Copy link
Contributor Author

damikdk commented Oct 26, 2018

Sup :)

@iRoachie
Copy link
Collaborator

iRoachie commented Nov 6, 2018

Hey @damikdk when i ran this example all i got was blank screen
simulator screen shot - iphone xr - 2018-11-06 at 03 29 47

@damikdk
Copy link
Contributor Author

damikdk commented Nov 7, 2018

Sorry, my bad. Fixed now

@iRoachie iRoachie closed this Nov 12, 2018
@iRoachie iRoachie reopened this Nov 12, 2018
@iRoachie iRoachie changed the base branch from next to master January 17, 2019 05:47
@iRoachie iRoachie changed the base branch from master to next January 17, 2019 05:48
@damikdk
Copy link
Contributor Author

damikdk commented Sep 10, 2019

Anniversary! 🎉🎉🎉 JK

@iRoachie
Copy link
Collaborator

😅 Still interested in getting this in? Totally got buried in my email

@pie6k
Copy link

pie6k commented Mar 13, 2020

any chance to have it merged?

@riledv
Copy link

riledv commented Nov 12, 2022

@iRoachie merge it please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants