Skip to content

Commit

Permalink
[libc++] Fix CI issues recently introduced by localization changes (l…
Browse files Browse the repository at this point in the history
…lvm#116216)

After a recent Github Actions runner policy change [1], the version of
Xcode included in the macos-14 image went from Xcode 16 to Xcode 15,
breaking our build bots.

This moves the bots to the macos 15 (public preview) image, which
contains Xcode 16.

Also, adjust an UNSUPPORTED annotation that was incorrectly targeting
macos 13.7 when it should have been targeting a version of AppleClang.

[1]: actions/runner-images#10703
  • Loading branch information
ldionne authored and akshayrdeodhar committed Nov 18, 2024
1 parent fcaa902 commit 5ba2d2a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/libcxx-build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,13 @@ jobs:
matrix:
include:
- config: generic-cxx03
os: macos-latest
os: macos-15
- config: generic-cxx23
os: macos-latest
os: macos-15
- config: generic-modules
os: macos-latest
os: macos-15
- config: apple-configuration
os: macos-latest
os: macos-15
- config: apple-system
os: macos-13
- config: apple-system-hardened
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@
// Pass-by-value arguments with alignment greater than register width are not supported.
// XFAIL: target=powerpc{{.*}}-ibm-{{.*}} && (clang-17 || clang-18)

// FIXME: The following issue occurs on macOS 13.7 with Apple clang 15.0.0:
// clang: error: unable to execute command: Illegal instruction: 4
// XFAIL: target=x86_64-apple-macosx13.7
// This test crashes AppleClang 15 but not later versions.
// UNSUPPORTED: apple-clang-15

// FIXME: The following issue occurs on Windows to Armv7 Ubuntu Linux:
// Assertion failed: N->getValueType(0) == MVT::v1i1 && "Expected v1i1 type"
Expand Down

0 comments on commit 5ba2d2a

Please sign in to comment.