Progress bar stays loading forever (until completed is called) and an… #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imation is much smother
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes Bar completes before it is asked to complete #61
until the
complete
method is called, whenstart
is called.the start method)
the timing function being linear makes the loading way more smoother).
completed
callback from thestart
method, because that callback will never be called under the new algorithm for the bar growth.What is the current behavior? (You can also link to an open issue here)
When
start
is called, the loading bar loads for 50 seconds until it looks completed.What is the new behavior (if this is a feature change)?
When
start
is called, the bar stays loading forever, showing increments of lower amounts as time progresses allowing for it to stay doing increments to the bar forever.(9%, 17%, 25%, 32%, 38%, 44%, 49%, 53%, 58%, 61%, 65%, 68%, 71%, 74%, 76%, 78%, 80%, 82%, 84%, 85%, 86%, 88%, 89%, ...) but no 100%.
Other information:
The velocity of this change can be modified by changing the field
growVelocity
in the service, and the higher the value, the more quickly the bar will look full.