fix(messaging): Add verification process for the window messaging #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1natsu172
commented
Nov 3, 2024
| id: getNextId(), | ||
| type: type, | ||
| data, | ||
| timestamp: Date.now(), | ||
| }; | ||
| const message = (await config.verifyMessageData?.(_message)) ?? _message; |
There was a problem hiding this comment.
Verification of this data
await sendMessage('getSomething``, { please: "verify this data"});
1natsu172
commented
Nov 3, 2024
Comment on lines
+155
to
+157
| .then(res => { | ||
| return config.verifyMessageData?.(res) ?? res; | ||
| }) |
There was a problem hiding this comment.
Verification of this data.
onMessage("getSomething", (data) => {
return { please: "verify this data"}
});
aklinker1
approved these changes
Nov 13, 2024
aklinker1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #55
Why cause issue
When sending message between windows, if there is data that cannot be serialized, the response will be
null. This causes aNo responseerror.Solution
It needs to be an error that the user can understand. Add a verification process before the browser sends the message to improve this.