feat(fake-browser): Upgrade webextension-polyfill types to 0.10.5
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aklinker1. |
aklinker1
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Thanks for opening a PR!
Since the session storage needs to raise the version of @types/webextension-polyfill to 0.10.5,
we also need to mock the new methods unrelated to the session storage, otherwise caused the type check to fail.
Should I do that in this PR?
Yeah, we should do that in this PR as well. I updated the PR title to reflect this.
aklinker1
changed the title
webextension-polyfill types to 0.10.5
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
aklinker1
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solved #45