Sealed uninherited internal classes in Akka.Streams (#6932)

Co-authored-by: Lehonti Ramos <lehonti@ramos>
akkadotnet · Oct 2, 2023 · 1af82a7 · 1af82a7
1 parent 9096347
commit 1af82a7
Show file tree

Hide file tree

Showing 21 changed files with 41 additions and 43 deletions.
diff --git a/src/core/Akka.Streams.Tests/Implementation/FixedBufferSpec.cs b/src/core/Akka.Streams.Tests/Implementation/FixedBufferSpec.cs
@@ -164,8 +164,8 @@ public void FixedSizeBuffer_must_work_when_indexes_wrap_around_at_Int_MaxValue(i
                     buf.Dequeue().Should().Be(elem);
             }
         }
-        
-        private class CheatPowerOfTwoFixedSizeBuffer : PowerOfTwoFixedSizeBuffer<int>
+
+        private sealed class CheatPowerOfTwoFixedSizeBuffer : PowerOfTwoFixedSizeBuffer<int>
         {
             public CheatPowerOfTwoFixedSizeBuffer(int size) : base(size)
             {
@@ -174,7 +174,7 @@ public CheatPowerOfTwoFixedSizeBuffer(int size) : base(size)
             }
         }
 
-        private class CheatModuloFixedSizeBuffer : ModuloFixedSizeBuffer<int>
+        private sealed class CheatModuloFixedSizeBuffer : ModuloFixedSizeBuffer<int>
         {
             public CheatModuloFixedSizeBuffer(int size) : base(size)
             {

diff --git a/src/core/Akka.Streams/Actors/ActorPublisher.cs b/src/core/Akka.Streams/Actors/ActorPublisher.cs
@@ -747,7 +747,7 @@ public OnErrorBlock(Exception cause, bool stop)
     /// <summary>
     /// TBD
     /// </summary>
-    internal class ActorPublisherState : ExtensionIdProvider<ActorPublisherState>, IExtension
+    internal sealed class ActorPublisherState : ExtensionIdProvider<ActorPublisherState>, IExtension
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Dsl/Hub.cs b/src/core/Akka.Streams/Dsl/Hub.cs
@@ -87,7 +87,7 @@ public ProducerFailed(string message, Exception cause) : base(message, cause)
     /// INTERNAL API
     /// </summary>
     /// <typeparam name="T">The type of element emitted by the MergeHub</typeparam>
-    internal class MergeHub<T> : GraphStageWithMaterializedValue<SourceShape<T>, Sink<T, NotUsed>>
+    internal sealed class MergeHub<T> : GraphStageWithMaterializedValue<SourceShape<T>, Sink<T, NotUsed>>
     {
         #region Internal classes
 
@@ -526,7 +526,7 @@ public static Sink<T, Source<T, NotUsed>> Sink<T>(int bufferSize)
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class BroadcastHub<T> : GraphStageWithMaterializedValue<SinkShape<T>, Source<T, NotUsed>>
+    internal sealed class BroadcastHub<T> : GraphStageWithMaterializedValue<SinkShape<T>, Source<T, NotUsed>>
     {
         #region internal classes
 
@@ -1296,7 +1296,7 @@ public interface IConsumerInfo
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class PartitionHub<T> : GraphStageWithMaterializedValue<SinkShape<T>, Source<T, NotUsed>>
+    internal sealed class PartitionHub<T> : GraphStageWithMaterializedValue<SinkShape<T>, Source<T, NotUsed>>
     {
         #region queue implementation
 

diff --git a/src/core/Akka.Streams/Dsl/Internal/InternalFlowOperations.cs b/src/core/Akka.Streams/Dsl/Internal/InternalFlowOperations.cs
@@ -1421,7 +1421,7 @@ public static SubFlow<T, TMat, TClosed> GroupBy<T, TMat, TKey, TClosed>(
         /// <typeparam name="TOut">TBD</typeparam>
         /// <typeparam name="TMat">TBD</typeparam>
         /// <typeparam name="TKey">TBD</typeparam>
-        internal class GroupByMergeBack<TOut, TMat, TKey> : IMergeBack<TOut, TMat>
+        internal sealed class GroupByMergeBack<TOut, TMat, TKey> : IMergeBack<TOut, TMat>
         {
             private readonly IFlow<TOut, TMat> _self;
             private readonly int _maxSubstreams;
@@ -1539,7 +1539,7 @@ TClosed finish(Sink<T, TMat> s)
         /// </summary>
         /// <typeparam name="TOut">TBD</typeparam>
         /// <typeparam name="TMat">TBD</typeparam>
-        internal class SplitWhenMergeBack<TOut, TMat> : IMergeBack<TOut, TMat>
+        internal sealed class SplitWhenMergeBack<TOut, TMat> : IMergeBack<TOut, TMat>
         {
             private readonly IFlow<TOut, TMat> _self;
             private readonly Func<TOut, bool> _predicate;
@@ -1644,7 +1644,7 @@ TClosed finish(Sink<T, TMat> s)
         /// </summary>
         /// <typeparam name="TOut">TBD</typeparam>
         /// <typeparam name="TMat">TBD</typeparam>
-        internal class SplitAfterMergeBack<TOut, TMat> : IMergeBack<TOut, TMat>
+        internal sealed class SplitAfterMergeBack<TOut, TMat> : IMergeBack<TOut, TMat>
         {
             private readonly IFlow<TOut, TMat> _self;
             private readonly Func<TOut, bool> _predicate;

diff --git a/src/core/Akka.Streams/Dsl/RestartFlow.cs b/src/core/Akka.Streams/Dsl/RestartFlow.cs
@@ -454,13 +454,13 @@ public Delay(TimeSpan duration)
         public override string ToString() => $"Duration({Duration})";
     }
     }
-    
+
     /// <summary>
     /// Returns a flow that is almost identical but delays propagation of cancellation from downstream to upstream.
     /// Once the down stream is finished calls to onPush are ignored
     /// </summary>
     /// <typeparam name="T"></typeparam>
-    internal class DelayCancellationStage<T> : SimpleLinearGraphStage<T>
+    internal sealed class DelayCancellationStage<T> : SimpleLinearGraphStage<T>
     {
         private readonly TimeSpan _delay;
 

diff --git a/src/core/Akka.Streams/Dsl/UnfoldFlow.cs b/src/core/Akka.Streams/Dsl/UnfoldFlow.cs
@@ -75,7 +75,7 @@ public void OnDownstreamFinish(Exception cause)
     }
 
     [InternalApi]
-    internal class FanOut2UnfoldingStage<TIn, TState, TOut> : GraphStage<FanOutShape<TIn, TState, TOut>>
+    internal sealed class FanOut2UnfoldingStage<TIn, TState, TOut> : GraphStage<FanOutShape<TIn, TState, TOut>>
     {
         private readonly Func<FanOutShape<TIn, TState, TOut>, UnfoldFlowGraphStageLogic<TIn, TState, TOut>> _generateGraphStageLogic;
 

diff --git a/src/core/Akka.Streams/Implementation/ActorProcessor.cs b/src/core/Akka.Streams/Implementation/ActorProcessor.cs
@@ -41,7 +41,7 @@ public static ActorProcessor<TIn, TOut> Create<TIn, TOut>(IActorRef impl)
     /// </summary>
     /// <typeparam name="TIn">TBD</typeparam>
     /// <typeparam name="TOut">TBD</typeparam>
-    internal class ActorProcessor<TIn, TOut> : ActorPublisher<TOut>, IProcessor<TIn, TOut>
+    internal sealed class ActorProcessor<TIn, TOut> : ActorPublisher<TOut>, IProcessor<TIn, TOut>
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/ActorRefBackpressureSinkStage.cs b/src/core/Akka.Streams/Implementation/ActorRefBackpressureSinkStage.cs
@@ -17,7 +17,7 @@ namespace Akka.Streams.Implementation
     /// INTERNAL API
     /// </summary>
     /// <typeparam name="TIn">TBD</typeparam>
-    internal class ActorRefBackpressureSinkStage<TIn> : GraphStage<SinkShape<TIn>>
+    internal sealed class ActorRefBackpressureSinkStage<TIn> : GraphStage<SinkShape<TIn>>
     {
         #region internal classes 
 

diff --git a/src/core/Akka.Streams/Implementation/EnumerableActorName.cs b/src/core/Akka.Streams/Implementation/EnumerableActorName.cs
@@ -41,7 +41,7 @@ public static EnumerableActorName Create(string prefix)
     /// <summary>
     /// TBD
     /// </summary>
-    internal class EnumerableActorNameImpl : EnumerableActorName
+    internal sealed class EnumerableActorNameImpl : EnumerableActorName
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/Fusing/ActorGraphInterpreter.cs b/src/core/Akka.Streams/Implementation/Fusing/ActorGraphInterpreter.cs
@@ -1149,7 +1149,7 @@ internal interface IActorOutputBoundary
         /// TBD
         /// </summary>
         /// <typeparam name="T">TBD</typeparam>
-        internal class ActorOutputBoundary<T> : DownstreamBoundaryStageLogic, IActorOutputBoundary
+        internal sealed class ActorOutputBoundary<T> : DownstreamBoundaryStageLogic, IActorOutputBoundary
         {
             #region InHandler
             private sealed class InHandler : Stage.InHandler

diff --git a/src/core/Akka.Streams/Implementation/Fusing/StreamOfStreams.cs b/src/core/Akka.Streams/Implementation/Fusing/StreamOfStreams.cs
@@ -8,7 +8,6 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
-using Akka.Annotations;
 using Akka.Event;
 using Akka.Pattern;
 using Akka.Streams.Actors;
@@ -1000,7 +999,7 @@ internal interface IState
         /// <summary>
         /// Not yet materialized and no command has been scheduled
         /// </summary>
-        internal class Uninitialized : IState
+        internal sealed class Uninitialized : IState
         {
             public static readonly Uninitialized Instance = new();
 
@@ -1025,7 +1024,7 @@ protected CommandScheduledBeforeMaterialization(ICommand command)
         /// <summary>
         /// A RequestOne command was scheduled before materialization
         /// </summary>
-        internal class RequestOneScheduledBeforeMaterialization : CommandScheduledBeforeMaterialization
+        internal sealed class RequestOneScheduledBeforeMaterialization : CommandScheduledBeforeMaterialization
         {
             public static readonly RequestOneScheduledBeforeMaterialization Instance = new(RequestOne.Instance);
 
@@ -1054,7 +1053,7 @@ internal interface ICommand
         {
         }
 
-        internal class RequestOne : ICommand
+        internal sealed class RequestOne : ICommand
         {
             public static readonly RequestOne Instance = new();
 

diff --git a/src/core/Akka.Streams/Implementation/IO/FilePublisher.cs b/src/core/Akka.Streams/Implementation/IO/FilePublisher.cs
@@ -23,7 +23,7 @@ namespace Akka.Streams.Implementation.IO
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class FilePublisher : Actors.ActorPublisher<ByteString>
+    internal sealed class FilePublisher : Actors.ActorPublisher<ByteString>
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/IO/FileSubscriber.cs b/src/core/Akka.Streams/Implementation/IO/FileSubscriber.cs
@@ -20,7 +20,7 @@ namespace Akka.Streams.Implementation.IO
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class FileSubscriber : ActorSubscriber
+    internal sealed class FileSubscriber : ActorSubscriber
     {
         /// <summary>
         /// TBD
@@ -208,7 +208,7 @@ private void CloseAndComplete(Try<IOResult> result)
             }
         }
 
-        internal class FlushSignal
+        internal sealed class FlushSignal
         {
             public static readonly FlushSignal Instance = new();
             private FlushSignal() { }

diff --git a/src/core/Akka.Streams/Implementation/IO/InputStreamPublisher.cs b/src/core/Akka.Streams/Implementation/IO/InputStreamPublisher.cs
@@ -13,14 +13,13 @@
 using Akka.IO;
 using Akka.Streams.Actors;
 using Akka.Streams.IO;
-using Akka.Util;
 
 namespace Akka.Streams.Implementation.IO
 {
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class InputStreamPublisher : Actors.ActorPublisher<ByteString>
+    internal sealed class InputStreamPublisher : Actors.ActorPublisher<ByteString>
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/IO/InputStreamSinkStage.cs b/src/core/Akka.Streams/Implementation/IO/InputStreamSinkStage.cs
@@ -19,7 +19,7 @@ namespace Akka.Streams.Implementation.IO
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class InputStreamSinkStage : GraphStageWithMaterializedValue<SinkShape<ByteString>, Stream>
+    internal sealed class InputStreamSinkStage : GraphStageWithMaterializedValue<SinkShape<ByteString>, Stream>
     {
         #region internal classes
 
@@ -33,7 +33,7 @@ internal interface IAdapterToStageMessage
         /// <summary>
         /// TBD
         /// </summary>
-        internal class ReadElementAcknowledgement : IAdapterToStageMessage
+        internal sealed class ReadElementAcknowledgement : IAdapterToStageMessage
         {
             /// <summary>
             /// TBD
@@ -49,7 +49,7 @@ private ReadElementAcknowledgement()
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Close : IAdapterToStageMessage
+        internal sealed class Close : IAdapterToStageMessage
         {
             /// <summary>
             /// TBD
@@ -92,7 +92,7 @@ public Data(ByteString bytes)
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Finished : IStreamToAdapterMessage
+        internal sealed class Finished : IStreamToAdapterMessage
         {
             /// <summary>
             /// TBD
@@ -108,7 +108,7 @@ private Finished()
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Initialized : IStreamToAdapterMessage
+        internal sealed class Initialized : IStreamToAdapterMessage
         {
             /// <summary>
             /// TBD
@@ -272,7 +272,7 @@ public override ILogicAndMaterializedValue<Stream> CreateLogicAndMaterializedVal
     /// INTERNAL API
     /// InputStreamAdapter that interacts with InputStreamSinkStage
     /// </summary>
-    internal class InputStreamAdapter : Stream
+    internal sealed class InputStreamAdapter : Stream
     {
 #region not supported 
 

diff --git a/src/core/Akka.Streams/Implementation/IO/OutputStreamSourceStage.cs b/src/core/Akka.Streams/Implementation/IO/OutputStreamSourceStage.cs
@@ -23,7 +23,7 @@ namespace Akka.Streams.Implementation.IO
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class OutputStreamSourceStage : GraphStageWithMaterializedValue<SourceShape<ByteString>, Stream>
+    internal sealed class OutputStreamSourceStage : GraphStageWithMaterializedValue<SourceShape<ByteString>, Stream>
     {
         #region internal classes
 
@@ -37,7 +37,7 @@ internal interface IAdapterToStageMessage
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Flush : IAdapterToStageMessage
+        internal sealed class Flush : IAdapterToStageMessage
         {
             /// <summary>
             /// TBD
@@ -52,7 +52,7 @@ private Flush()
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Close : IAdapterToStageMessage
+        internal sealed class Close : IAdapterToStageMessage
         {
             /// <summary>
             /// TBD
@@ -74,7 +74,7 @@ internal interface IDownstreamStatus
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Ok : IDownstreamStatus
+        internal sealed class Ok : IDownstreamStatus
         {
             /// <summary>
             /// TBD
@@ -89,7 +89,7 @@ private Ok()
         /// <summary>
         /// TBD
         /// </summary>
-        internal class Canceled : IDownstreamStatus
+        internal sealed class Canceled : IDownstreamStatus
         {
             /// <summary>
             /// TBD
@@ -315,7 +315,7 @@ public override ILogicAndMaterializedValue<Stream> CreateLogicAndMaterializedVal
     /// <summary>
     /// TBD
     /// </summary>
-    internal class OutputStreamAdapter : Stream
+    internal sealed class OutputStreamAdapter : Stream
     {
         #region not supported
 

diff --git a/src/core/Akka.Streams/Implementation/IO/OutputStreamSubscriber.cs b/src/core/Akka.Streams/Implementation/IO/OutputStreamSubscriber.cs
@@ -19,7 +19,7 @@ namespace Akka.Streams.Implementation.IO
     /// <summary>
     /// INTERNAL API
     /// </summary>
-    internal class OutputStreamSubscriber : ActorSubscriber
+    internal sealed class OutputStreamSubscriber : ActorSubscriber
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/Sinks.cs b/src/core/Akka.Streams/Implementation/Sinks.cs
@@ -150,7 +150,7 @@ protected SinkShape<TIn> AmendShape(Attributes attrs)
     /// </summary>
     /// <typeparam name="TIn">TBD</typeparam>
     [InternalApi]
-    internal class PublisherSink<TIn> : SinkModule<TIn, IPublisher<TIn>>
+    internal sealed class PublisherSink<TIn> : SinkModule<TIn, IPublisher<TIn>>
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Implementation/Transfer.cs b/src/core/Akka.Streams/Implementation/Transfer.cs
@@ -303,7 +303,7 @@ private NotInitialized()
     /// <summary>
     /// TBD
     /// </summary>
-    internal class WaitingForUpstreamSubscription : TransferState
+    internal sealed class WaitingForUpstreamSubscription : TransferState
     {
         /// <summary>
         /// TBD

diff --git a/src/core/Akka.Streams/Stage/AbstractStage.cs b/src/core/Akka.Streams/Stage/AbstractStage.cs
@@ -16,7 +16,7 @@ namespace Akka.Streams.Stage
     /// </summary>
     /// <typeparam name="TIn">TBD</typeparam>
     /// <typeparam name="TOut">TBD</typeparam>
-    internal class PushPullGraphLogic<TIn, TOut> : GraphStageLogic, IDetachedContext<TOut>
+    internal sealed class PushPullGraphLogic<TIn, TOut> : GraphStageLogic, IDetachedContext<TOut>
     {
 #pragma warning disable CS0618 // Type or member is obsolete
         private AbstractStage<TIn, TOut> _currentStage;

diff --git a/src/core/Akka.Streams/Util/IteratorAdapter.cs b/src/core/Akka.Streams/Util/IteratorAdapter.cs
@@ -34,7 +34,7 @@ internal interface IIterator<out T>
     /// TBD
     /// </summary>
     /// <typeparam name="T">TBD</typeparam>
-    internal class IteratorAdapter<T> : IIterator<T>
+    internal sealed class IteratorAdapter<T> : IIterator<T>
     {
         private readonly IEnumerator<T> _enumerator;
         private bool? _hasNext;