chore: Verbose logs after retrying the projection a number of times #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
commented
Nov 15, 2024
| .withLogLevel(LogLevels.Warning) | ||
| // Once we have retried many times, it could still be a transient failure but is | ||
| // more likely to be a permanent problem, so increase verbosity/include full stack trace | ||
| .withVerboseLogsAfter(5)) |
There was a problem hiding this comment.
Not sure if this should perhaps be from config and tuneable or if just having a hardcoded sensible default is enough. With the default settings this means that it starts printing a full stack trace after retrying and backing off 5 times ( ~1 minute and 20 seconds.)
There was a problem hiding this comment.
We could also just explicitly define it in gRPC replication, and recommend/show setting it for direct gRPC usage instead of defaulting here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on an upstream release of Akka