Skip to content

Commit

Permalink
fix installation on localized/l10n versions of firefox
Browse files Browse the repository at this point in the history
resource://gre/modules/addons/XPIInstall.jsm tries to get the Addon's
name in loadManifest(). On localized versions supported by VimFx, this
is read from install.rdf's <em:localized> section. We assumed that when
this block does not include an <em:name> element, that it would use the
one from the non-localized section. That does not seem to have been
true, ever. Even l10n-Firefox 52 balks here (using 0.21.0 and 0.22.2),
as well as i10n-Firefox 68.

fixes: #982
  • Loading branch information
girst committed Nov 11, 2022
1 parent b7f49f4 commit 2b7b4ea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions extension/install.rdf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
{{#descriptions}}
<em:localized>
<Description>
<em:name>VimFx</em:name>
<em:locale>{{locale}}</em:locale>
<em:description>{{description}}</em:description>
</Description>
Expand Down

0 comments on commit 2b7b4ea

Please sign in to comment.