Skip to content

Commit

Permalink
fix 'eb' for fx71
Browse files Browse the repository at this point in the history
browser.xhtml was restructured between firefox 69 and 71, and hints were
not displaying any more (they still worked, adding to the confusion). It
turns out that moving the hints-containert before #navigator-toolbox is
sufficient. But insertBefore()ing that element breaks Waterfox 56, as
this element does not exist there (which is a bit strange, as the docs
say, insertBefore should degrade gracefully to appendChild in such a
case). However, we can just insert it as the first element below
the #main-window element, which works a treat.
  • Loading branch information
girst committed Oct 19, 2019
1 parent 75cce0e commit 1791f88
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions extension/lib/commands.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -736,8 +736,10 @@ commands.click_browser_element = ({vim}) ->
})
MarkerContainer.remove(window) # Better safe than sorry.
markerContainer.container.classList.add('ui')
window.document.getElementById('main-window').appendChild(
markerContainer.container
mainWindow = window.document.getElementById('main-window')
mainWindow.insertBefore(
markerContainer.container,
mainWindow.firstChild
)

[firstWrappers, secondWrappers] =
Expand Down

0 comments on commit 1791f88

Please sign in to comment.