Fix type for Dropdown.Surtitle #20376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelanos
force-pushed
the
fix-dropdown-surtitle-type
branch
from
c079b4a
to
49e284d
Compare
sdelanos
force-pushed
the
fix-dropdown-surtitle-type
branch
from
cb1a52a
to
c24d17f
Compare
|
A new version of the staging env has been deployed 🎉 |
1 similar comment
|
A new version of the staging env has been deployed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(first contrib, tell me if I'm missing anything)
Description
When using the Dropdown.Surtitle element from the DSM I ran into an error when using the examples provided. The component didn't allow children because it is not in the props.
When testing locally, my quick&dirty fix was to modify the node_modules type directly
It worked well so I'm now adding the fix here.
More info
The example I tried to use: https://dsm.akeneo.com/?path=/docs/components-dropdown--surtitle-item#surtitle-item
The error:
Definition Of Done