Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Symfony 7 #72

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Support Symfony 7 #72

merged 1 commit into from
Dec 8, 2023

Conversation

Beninho
Copy link
Contributor

@Beninho Beninho commented Dec 4, 2023

This PR proposes an update to support Symfony 7.0.

Please note: phpspec does not currently support Symfony 7

nmarniesse
nmarniesse approved these changes Dec 4, 2023
View reviewed changes
Copy link

@nmarniesse nmarniesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM after fix

composer.json Outdated Show resolved Hide resolved
@Beninho Beninho merged commit c4568a3 into master Dec 8, 2023
5 checks passed
@Beninho Beninho deleted the sf7-support branch December 8, 2023 13:05
@jakzal
Copy link

jakzal commented Dec 10, 2023

Unfortunately, this change breaks the app:

$ php-coupling-detector list

PHP Fatal error:  Declaration of Akeneo\CouplingDetector\Console\Command\DetectCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/toolbox/toolbox/build/tools/.composer/vendor-bin/tools/vendor/akeneo/php-coupling-detector/src/Console/Command/DetectCommand.php on line 71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarniesse nmarniesse nmarniesse approved these changes

@jmleroux jmleroux jmleroux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Beninho @jakzal @jmleroux @nmarniesse