Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop PathUtil #464

Merged
merged 4 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 3.15.0
* `g.Storage` とその周辺のコードを削除
* ゲーム開発者に影響はありません。
* `g.PathUtil` を @akashic/game-configuration から参照するように

### エンジン開発者への影響
* `g.Game#storage` が削除されます。
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@akashic/akashic-engine",
"version": "3.14.2",
"version": "3.15.0",
"description": "The core library of Akashic Engine",
"main": "index.js",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/Module.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { PathUtil } from "@akashic/game-configuration/lib/utils/PathUtil";
import type { Module as PdiModule, ScriptAssetRuntimeValue, ScriptAssetRuntimeValueBase } from "@akashic/pdi-types";
import { PathUtil } from "./PathUtil";
import type { Require } from "./Require";

export interface ModuleParameterObject {
Expand Down
2 changes: 1 addition & 1 deletion src/ModuleManager.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { PathUtil } from "@akashic/game-configuration/lib/utils/PathUtil";
import type { Asset, ScriptAssetRuntimeValueBase } from "@akashic/pdi-types";
import type { AssetManager, OneOfAsset } from "./AssetManager";
import { ExceptionFactory } from "./ExceptionFactory";
import { Module } from "./Module";
import { PathUtil } from "./PathUtil";
import type { RequireCacheable } from "./RequireCacheable";
import { RequireCachedValue } from "./RequireCachedValue";
import { ScriptAssetContext } from "./ScriptAssetContext";
Expand Down
126 changes: 0 additions & 126 deletions src/PathUtil.ts

This file was deleted.

174 changes: 0 additions & 174 deletions src/__tests__/PathUtilSpec.ts

This file was deleted.

4 changes: 3 additions & 1 deletion src/index.common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export { Module } from "./Module";
export { ShaderProgram } from "./ShaderProgram";
export { VideoSystem } from "./VideoSystem";

// 後方互換性のため PathUtil のみ reexport する。
export { PathUtil } from "@akashic/game-configuration/lib/utils/PathUtil";

export * from "./entities/CacheableE";
export * from "./entities/E";
export * from "./entities/FilledRect";
Expand Down Expand Up @@ -59,7 +62,6 @@ export * from "./OperationPlugin";
export * from "./OperationPluginManager";
export * from "./OperationPluginOperation";
export * from "./OperationPluginStatic";
export * from "./PathUtil";
export * from "./Player";
export * from "./PointEventResolver";
export * from "./RandomGenerator";
Expand Down