Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lease service: SendManifest #212

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Lease service: SendManifest #212

wants to merge 14 commits into from

Conversation

andrewhare
Copy link
Contributor

@andrewhare andrewhare commented Mar 14, 2024

Implements SendManifest from akash-network/akash-api#130.

Resolves akash-network/support#191

A few other things that are in this:

  • A simple gRPC test harness. @troian mentioned that there are other gRPC tests, but I used this to familiarize myself with all the different interfaces behind the service, how they interact, and what they actually call.
  • I refactored the mTLS logic into a single function. Eventually, the REST interface will be gone, but while we maintain both servers, we won't have multiple implementations to maintain as well.
  • A small refactor to the grpc.Serve function to make it easier to test.
  • I broke out the implementation of each proto service into its own file and its own struct. The main server struct composes these.

@andrewhare andrewhare requested review from boz and troian as code owners March 14, 2024 21:26
@andrewhare andrewhare requested a review from chainzero March 20, 2024 19:31
gateway/grpc/server.go Outdated Show resolved Hide resolved
gateway/grpc/server.go Outdated Show resolved Hide resolved
gateway/grpc/server.go Outdated Show resolved Hide resolved
gateway/grpc/server.go Outdated Show resolved Hide resolved
gateway/utils/utils.go Outdated Show resolved Hide resolved
gateway/rest/client.go Show resolved Hide resolved
gateway/grpc/server.go Outdated Show resolved Hide resolved
cmd/provider-services/cmd/run.go Show resolved Hide resolved
@andrewhare andrewhare requested a review from troian March 21, 2024 22:44
@andrewhare andrewhare force-pushed the feat/lease-service branch from 114730e to 8154508 Compare April 4, 2024 04:22
@andrewhare andrewhare mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement send manifest via GRPC endpoint
2 participants