chore(examples): make sure create_deployment.ts example work #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
changed the title
ygrishajev
force-pushed
the
feature/examples
branch
from
df93c79 to
f73bc10
Compare
baktun14
reviewed
May 14, 2024
ygrishajev
force-pushed
the
feature/examples
branch
from
f73bc10 to
ce3e1b6
Compare
Also update types in other examples refs akash-network/akashjs#184
ygrishajev
force-pushed
the
feature/examples
branch
from
ce3e1b6 to
81cb46a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 71.57% 71.57%
=======================================
Files 23 23
Lines 795 795
Branches 198 198
=======================================
Hits 569 569
- Misses 217 218 +1
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. |
baktun14
approved these changes
May 15, 2024
|
🎉 This PR is included in version 0.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that create_deployment.ts works after code generation is moved to
akash-api. It also updates types in other examples.Another fix is deprecated certificate types added.
NOTE: this PR needs akash-network/akash-api#175 to be merged and published