Fix warnings for default step #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change makes sense to me. Guess this repo's CI config is out of date enough that we're getting some build failures, but I'll get to work fixing those on main, since it's not related to the actual change here. The package is long overdue for a version bump to line it up with supported Elixir versions anyhow. 😅 Thanks for the fix! |
|
Just published this fix in https://hex.pm/packages/remote_ip/1.2.0 Let me know if there are any problems! |
|
Thank you, will try it out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warning
If the step syntax breaks for 1.10 and/or 1.11 it might be worth it to bump the minimum version of Elixir to 1.12 based on this compatibility doc: https://hexdocs.pm/elixir/1.16.3/compatibility-and-deprecations.html