Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for php-parser 5 #85

Merged
merged 5 commits into from
May 11, 2024
Merged

Conversation

jasonvarga
Copy link
Contributor

This PR adds support for nikic/php-parser 5.0.
It removes support for 4.0.

This has become necessary as PHPUnit 11 requires 5.0. PHPUnit 11 is now the default in Laravel.

@ajthinking
Copy link
Owner

Hi Jason, thanks for this!
Can you see what is failing here?
image

@jasonvarga
Copy link
Contributor Author

I'm not sure about that one. It fails during setup of the image. It's not a PHPUnit failure.

@jasonvarga
Copy link
Contributor Author

jasonvarga commented May 10, 2024

It's because the composer command can't be found in that macos image.

CleanShot 2024-05-10 at 16 58 33

Then in the "cache dependencies" step, there is no path because it didnt get defined in the previous step.

As for why it's missing. I have no idea. It seems like it's not included with macos. Maybe it was at some point.

This failing step has nothing to do with this PR though. I would compare with previous workflow runs but there don't appear to be any. I have pushed an empty commit to the master branch on my fork to trigger the actions. You can see it failing there too.

@ajthinking
Copy link
Owner

Found a way! Happy to see youre still using this package❤️
Releasing 2.0.0 shortly as this will be a breaking change.

@ajthinking ajthinking merged commit d2c5cd0 into ajthinking:master May 11, 2024
8 checks passed
@ajthinking
Copy link
Owner

https://github.com/ajthinking/archetype/releases/tag/v2.0.0

Let me know if it needs any tweeking 👍

@jasonvarga
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants