Merge pull request #74 from ajthinking/fix-ast-insert-bug

Guard clause so we do not insert on non exist match

src/Support/AST/ASTQueryBuilder.php

@@ -352,9 +352,11 @@ public function insertStmts($newNodes): self
     public function insertStmt($newNode): self
     {
         $this->currentNodes()->each(function ($node) use ($newNode) {
-
             $target = $node->result;
 
+			// Do not insert things on empty results
+			if(is_array($target) && empty($target)) return;
+
             // Assume insertion targets namespace stmts (if present at index 0)
             if (is_array($target) && !empty($target) && get_class($target[0]) == 'PhpParser\\Node\\Stmt\Namespace_') {
                 $target = $target[0];

tests/Unit/Support/AST/ASTQueryBuilderTest.php

@@ -5,6 +5,8 @@
 use Archetype\Tests\Support\TestableASTQueryBuilder as ASTQueryBuilder;
 use PhpParser\BuilderFactory;
 
+use function PHPUnit\Framework\assertEquals;
+
 it('can be instanciated using an ast object', function() {
 	$ast = LaravelFile::load('public/index.php')->ast();
 	(new ASTQueryBuilder($ast))->assertInstanceOf(ASTQueryBuilder::class);
@@ -182,4 +184,23 @@
 		})
 		->classMethod('name->name')
 		->assertMatches(collect(['c', 'b', 'a']));
+});
+
+it('does not insert statements when no matches', function() {
+	$original = PHPFile::load('app/Providers/AppServiceProvider.php')->render();
+	$after = PHPFile::load('app/Providers/AppServiceProvider.php')
+		->astQuery()
+		->classMethod()
+		->where('blabala', 'xyxy')
+		->assertMatchCount(0)
+		->insertStmt(
+			new \PhpParser\Node\Stmt\Return_(
+				new \PhpParser\Node\Expr\Variable('this')
+			)
+		)
+		->commit()
+		->end()
+		->render();
+
+	assertEquals($original, $after);
 });