-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix flake for running this program; security& logging update. #3
Conversation
@ajm113 I also put up a PR to merge the patches included in this repo into openvpn itself. Unsure how they will respond (if it at all) - OpenVPN/openvpn#273. Note they don't merge from that repo - only from their mailing list - but they'll at least discuss the patch there. |
BTW, the name |
@m4dc4p Thank you so much again! I'll do a little testing today after/break from work. Sorry for the delay. I usually try my best to check on my GitHub, but also noticed I don't have email notifications enabled of my repos. 🙃
Thanks for discussing the patch with them at least. I think the patch is more or less AWS specific in general, but it would be nice to have some sort of flag or option in OpenVPN to enable us to use the slightly modified protocol without having to be forced to edit OpenVPN code.
I'll start updating README and the project URL some time today. 😄 |
Just a tiny update. The changes are great so far! I'm just doing a little more reading of Nix and how to utilize it and test the changes. Sorry it's taking me so long. I'll do a little more testing/reading this weekend. |
No worries! I'm actually exploring Here are some resources to get you started on nix. The ones you find one nixos.org aren't great :(
|
Thanks for the resources! I'm playing with the PR at the moment and found one issue so far running nix/flake. (Maybe it's just my inexperience getting the best of me here) When running via
By default on Linux you need root/administration permissions in order to interface with networking to create the tunnel. Reason why I wanted the Go code to handle this bit if you add a |
Oh, I’d forgotten about sudo (in my testing I set the sticky bit on the openvpn binary). If I don’t get a commit together, you can follow the same pattern I used to put the openvpn path into the config. I found a way to do this with expect so I don’t think I’ll continue with this solution much longer. |
Hey @m4dc4p ! Just following up, no rush at all, but is it okay if we move the nix changes out of this PR for now into it's own separate PR? I'd love to get some of your changes in at least for now. I just want to hold off on nix a tiny bit longer. We proposed the idea of offloading how the user wants to start the browser in PR #1. In theory should make your flake addition good to go once I make some changes how the cli executes a shell script. I just need a little more time testing the flow and making sure nothing breaks when trying to run it as nix package. Let me know if you have any question or if you want to offload anything on my end! :) |
No worries at all!
…On Mon, Mar 27, 2023 at 16:30 Andrew McRobb ***@***.***> wrote:
Hey @m4dc4p <https://github.com/m4dc4p> ! Just following up, no rush at
all, but is it okay if we move the nix changes out of this PR for now into
it's own separate PR? I'd love to get some of your changes in at least for
now. I just want to hold off on nix a tiny bit longer. We proposed the idea
of offloading how the user wants to start the browser in PR #1
<#1>. In theory should
make your flake addition good to go once I make some changes how the cli
executes a shell script.
Let me know if you have any question! :)
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAESAJHXRG7LY2SL3AUPCTW6IPK7ANCNFSM6AAAAAAVVRHGKE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Added flake definition so this program can be run easily via nix. * Added `user` and `group` setting to YAML configuration, allowing openvpn to run unprivileged (after initialization). * Nix flake app runs as `nobody:nobody`. * Added a "logLevel" flag to program and set default to "Info" so SAML response (credentials) aren't logged by default. * Updated README with instructions. Tested on MacOS x86; needs testing on M1 & Linux.
2ef4a7b
to
32284c9
Compare
Added flake definition so this program can be run easily via nix.
Added
user
andgroup
setting to YAML configuration, allowing openvpn to run unprivileged (after initialization).Nix flake app runs as
nobody:nobody
.Added a "logLevel" flag to program and set default to "Info" so SAML response (credentials) aren't logged by default.
Updated README with instructions.
Tested on MacOS x86; needs testing on M1 & Linux.