Improve tests for Kafka topic create and update

[ivanyu]

No description provided.

[eliax1996]

Syntattically it's fine, I'm asking a couple of question to understand also the semantics.

Are we executing similar tests in an end to end scenario against a real system?

Because they seems like a contract testing about the shape of the expected data. But, if we don't test that the provider is compliant with this specification, both the systems can succeed with the test suite but in reality they are talking a different language when deployed together they can fail.

Also here we have a dynamicity in the shape inside the test. We are not enforcing that the reply is of a certain shape but we are only enforcing that is containing exactly the same data that we have given to the other component, maybe we want also to have a set of keys that we expect always to have?

[ivanyu]

Are we executing similar tests in an end to end scenario against a real system?

Because they seems like a contract testing about the shape of the expected data. But, if we don't test that the provider is compliant with this specification, both the systems can succeed with the test suite but in reality they are talking a different language when deployed together they can fail.

No, we don't have end-to-end tests for this client (except for some internal Aiven testing). Most tests in test_cli.py don't test much beyond the CLI parsing. What I added are indeed contract tests: we "know" the Aiven API is correct, so we're testing the client is compliant with its schema.

[ivanyu]

Also here we have a dynamicity in the shape inside the test. We are not enforcing that the reply is of a certain shape but we are only enforcing that is containing exactly the same data that we have given to the other component, maybe we want also to have a set of keys that we expect always to have?

I don't understand this. Could you elaborate?

[eliax1996]

No, we don't have end-to-end tests for this client (except for some internal Aiven testing). Most tests in test_cli.py don't test much beyond the CLI parsing. What I added are indeed contract tests: we "know" the Aiven API is correct, so we're testing the client is compliant with its schema.

Now I got everything, sorry for not understanding it initially!
LGTM