Improving on HttpAssetLoader (#49)

* Update README.md * chore(): upgraded deps * chore(): load concrete location * fix(): correct decoding of cyrillic chars * chore(): updated readme. added HttpAssetLoader doc * fix(doc): update dir structure * Delete local AssetLoader class, update dependencies (#46) * Undo the breaking change of file names (#46) * contributing.md * added pipelines * fix linting problems * changelog * devversion * execute now * revert temp changes * update connectivity_plus, easy_localization, http and path_provider packages to latest version * chore(): upgraded deps * chore(): load concrete location * fix(): correct decoding of cyrillic chars * chore(): updated readme. added HttpAssetLoader doc * fix(doc): update dir structure --------- Co-authored-by: Frankdroid7 <[email protected]> Co-authored-by: Alexey Inkin <[email protected]> Co-authored-by: Benjamin Weber <[email protected]> Co-authored-by: BW Personal <[email protected]> Co-authored-by: Abdulaziz Rasulbek <[email protected]>
aissat · Oct 30, 2023 · f432cbf · f432cbf
1 parent 7c4abf7
commit f432cbf
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -14,6 +14,7 @@
 *.ipr
 *.iws
 .idea/
+.vscode/
 
 # The .vscode folder contains launch configuration and tasks you configure in
 # VS Code which you may wish to be included in version control, so this line

diff --git a/README.md b/README.md
@@ -55,3 +55,19 @@ void main(){
 ```
 
 3. All done!.
+
+
+### Loaders Specification
+
+#### HttpAssetLoader
+
+In order to use HttpAssetLoader you must provide a path to a folder (i.e. base path) where all your translations are placed like `https://example.com/translations`
+
+Your translations should be created as separate files with `.json` extension. Placing translations as individual files reduces the size of the file to load on application init.
+Example:
+
+```
+translations/
+├── en-US.json
+└── uk-UA.json
+```
diff --git a/lib/src/http_asset_loader.dart b/lib/src/http_asset_loader.dart
@@ -12,10 +12,10 @@ class HttpAssetLoader extends AssetLoader {
   Future<Map<String, dynamic>> load(String path, Locale locale) async {
     log('easy localization loader: load http $path');
     try {
-      var url = Uri.parse(path);
+      var url = Uri.parse('$path/${locale.toLanguageTag()}.json');
       return http
           .get(url)
-          .then((response) => json.decode(response.body.toString()));
+          .then((response) => json.decode(utf8.decode(response.bodyBytes)));
     } catch (e) {
       //Catch network exceptions
       return {};
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,7 @@ @@
     *.ipr
     *.iws
     .idea/
+    .vscode/
     # The .vscode folder contains launch configuration and tasks you configure in
     # VS Code which you may wish to be included in version control, so this line
@@ Expand Down @@