Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few updates to the code. #1822

Closed
wants to merge 8 commits into from
Closed

Conversation

vignesh1507
Copy link

@vignesh1507 vignesh1507 commented Sep 27, 2024

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

This code file doesn't contain anything so i am deleting it and moreover it isn't connected to any other file.
match.groups() returns a tuple of all groups. Using match.group(1) would be more appropriate and straightforward to extract the first capturing group.
@Lancetnik
Copy link
Member

I don't think, that such code comments are required, but not sure about documentation rewords
@kumaranvpl can you check the PR, please?

@Lancetnik Lancetnik added the documentation Improvements or additions to documentation label Oct 1, 2024
@kumaranvpl
Copy link
Collaborator

@Lancetnik Went through the changes. We can ignore and close this PR. The changes are extremely minor.

This is clearly generated with ChatGPT or some other LLM. Generating code or docs using LLM is not wrong. But these sorta PRs adds no value to the repo and wastes maintainers' time. We shouldn't be encouraging these kinda PRs.

@kumaranvpl
Copy link
Collaborator

@Lancetnik I am closing this PR. If you think it is not right to close the PR, please reopen it.

@kumaranvpl kumaranvpl closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants