Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GSSAPI (Kerberos) support #1633

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Feature: GSSAPI (Kerberos) support #1633

merged 6 commits into from
Aug 1, 2024

Conversation

roma-frolov
Copy link
Contributor

@roma-frolov roma-frolov commented Jul 30, 2024

Description

Fixed #1608

Type of change

  • New feature (a non-breaking change that adds functionality)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@roma-frolov
Copy link
Contributor Author

roma-frolov commented Jul 30, 2024

I want to clarify something: aiokafka with sasl_mechanism == GSSAPI requires the gssapi library (here). This library is optional in aiokafka (here).

What to do here? Add the gssapi library as optional? Are additional checks needed?

Copy link
Member

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the PR - it looks really good. But, if you added docs/docs_src file, can you please include it to the documentation the same way with other ones? Also, we are trying to cover all such examples by test, so can you please add test for it as well (tests/docs/etc directory)?

@@ -0,0 +1,9 @@
import ssl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you added this file, but didn't use it anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included this file in the documentation, but I already wrote the test earlier, here it is.
Is this enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Lancetnik
Lancetnik previously approved these changes Aug 1, 2024
@Lancetnik Lancetnik enabled auto-merge August 1, 2024 15:41
@Lancetnik Lancetnik added this pull request to the merge queue Aug 1, 2024
Merged via the queue into airtai:main with commit a36d282 Aug 1, 2024
29 checks passed
@kumaranvpl
Copy link
Collaborator

@Lancetnik This PR added Kerberos support only for aiokafka broker, not for confluent broker.
I have created a separate issue for it - #1669. I will create a PR for it in few mins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: GSSAPI (Kerberos) support
3 participants