-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: GSSAPI (Kerberos) support #1633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for the PR - it looks really good. But, if you added docs/docs_src file, can you please include it to the documentation the same way with other ones? Also, we are trying to cover all such examples by test, so can you please add test for it as well (tests/docs/etc
directory)?
@@ -0,0 +1,9 @@ | |||
import ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you added this file, but didn't use it anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included this file in the documentation, but I already wrote the test earlier, here it is.
Is this enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u a test for it too? https://github.com/airtai/faststream/blob/main/tests/docs/kafka/test_security.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@Lancetnik This PR added Kerberos support only for aiokafka broker, not for confluent broker. |
Description
Fixed #1608
Type of change
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh