Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pattern checking #1590

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

spataphore1337
Copy link
Contributor

Description

When adding `pattern' to the Kafka broker's Kafka subscriber, the pattern subscription itself did not occur. Checking for the presence of a pattern was added to the broker's usecase.
Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added enhancement New feature or request AioKafka Issues related to `faststream.kafka` module labels Jul 11, 2024
Copy link
Member

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test to check real message consuming, please

Lancetnik
Lancetnik previously approved these changes Jul 18, 2024
@Lancetnik Lancetnik enabled auto-merge July 18, 2024 17:25
…7/faststream into add-kafka-pattern-checking
@Lancetnik Lancetnik added this pull request to the merge queue Jul 18, 2024
Merged via the queue into airtai:main with commit 15cbe6b Jul 18, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AioKafka Issues related to `faststream.kafka` module enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants