Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepertoireGroup updates for v2.0, take two #773

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

scharch
Copy link
Contributor

@scharch scharch commented Mar 4, 2024

Replaces #748
Closes #578

So far: just some docs updates...

@scharch scharch added this to the AIRR 2.0 milestone Mar 4, 2024
@scharch
Copy link
Contributor Author

scharch commented May 10, 2024

I went very simple with the filters and just linked the docs page to what you have written for the API. If it looks ok, I will copy to the other files.

@schristley
Copy link
Member

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

@scharch
Copy link
Contributor Author

scharch commented May 17, 2024

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

The latter. Does that need to be in the schema explicitly?

@schristley
Copy link
Member

@scharch Are the filters only suppose to apply to rearrangements? Or are you expecting that it can be specified using a typed-key like in the example?

The latter. Does that need to be in the schema explicitly?

It doesn't need to be but I think it would make it more clear, as it's not obvious that should be done based upon the doc blurb. It would also make it more explicit what AIRR objects can be filtered. Thinking about it, using Repertoire: seems reasonable at the group level, but then that conflicts with the repertoires array...

@javh
Copy link
Contributor

javh commented Aug 12, 2024

From the call:

  • This might be stale.
  • Need to review.
  • Double check happiness level with Manifest.

@bcorrie
Copy link
Contributor

bcorrie commented Aug 12, 2024

Here is an example of what we should be able to do - I will revisit.

#578 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RepertoireGroup refinements
4 participants