Fix out of bounds read/writes #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
snappy-literal-overflow
branch
5 times, most recently
from
be9d74f
to
0ceca24
Compare
If the computed literal or match length was greater than Integer.MAX_VALUE, the value would overflow to a negative and cause a read before the beginning of the buffer.
martint
force-pushed
the
snappy-literal-overflow
branch
from
0ceca24
to
ab246b4
Compare
martint
changed the title
dain
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the computed literal length was greater than Integer.MAX_VALUE, the value would overflow to a negative and cause a read before the beginning of the buffer.
Fix other assorted missing bounds checks.