Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zlib decompressor #155

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add zlib decompressor #155

wants to merge 5 commits into from

Conversation

electrum
Copy link
Member

No description provided.

@airlift airlift deleted a comment from sonatype-lift bot Mar 31, 2023
Chaho12
Chaho12 reviewed Nov 29, 2023
View reviewed changes
Copy link

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans to merge this?

@electrum
Copy link
Member Author

This is currently several times slower than the JDK version that uses zlib, so I don't think we should merge this now.

@Chaho12
Copy link

Chaho12 commented Dec 15, 2023

How did you test and got results several times slower? TPC-H benchmark?
When I simply tested with this changes (note. i initialized with maxBuffersize), and did several tests with internal data including complex sqls with numerous joins, and simple ones with select count(*) from for reading orc zlib data, the results wasn't too bad. maximum of 20% slower?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaho12 Chaho12 Chaho12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@electrum @Chaho12