-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add s3-sync sidecar option (breaking values changes) #782
Conversation
Signed-off-by: Ben Stuart <[email protected]>
Signed-off-by: Ben Stuart <[email protected]>
Signed-off-by: Ben Stuart <[email protected]>
Signed-off-by: Ben Stuart <[email protected]>
Signed-off-by: Ben Stuart <[email protected]>
Signed-off-by: Ben Stuart <[email protected]>
Whats the hold up on this? |
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
@thesuperzapper Considering there is now a competing pull request for the same feature #828, which appears to have gotten more discussion, should I close this pull request? There are now conflicts, so I'm looking to determine if this is worth updating. |
@benchoncy I really do appreciate the effort you have put in. However, I am exceptionally unlikely to release any breaking changes in the values for the foreseeable future, as it's just too much work for people to migrate. If you think you can do a better job then the other PR at adding new values specifically for S3 (or something similar), then you're welcome to either update this PR or make a new one. |
What issues does your PR fix?
What does your PR do?
dags.gitSync
values todags.sync
dags.sync
valuesgitSync
and add new validation fors3
Checklist
For all Pull Requests
For releasing ONLY