Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-tiktok-marketing): add fivetran converter #57

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

topefolorunso
Copy link
Contributor

Resolves #31

@topefolorunso
Copy link
Contributor Author

Kindly review PR @marcosmarxm. Test passed for Postgres - Bigquery and Snowflake need a few adjustment on your end, correct?

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model is working @topefolorunso awesome work. There are some small details about casting some float variables in Bigquery. I'm gonna take a look and return to you

@marcosmarxm marcosmarxm changed the title Create dbt converter for Airbyte Tiktok Marketing source connector feat(source-tiktok-marketing): add fivetran converter Sep 3, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @topefolorunso working as expected :)

@marcosmarxm marcosmarxm merged commit 891725d into main Sep 3, 2024
1 check failed
@marcosmarxm marcosmarxm deleted the tope/tiktok_marketing_dbt_converter branch September 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dbt converter for Airbyte Tiktok Marketing source connector
2 participants