Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-recharge): add fivetran dbt converter #56

Merged
merged 15 commits into from
Aug 31, 2024

Conversation

rytismi
Copy link
Contributor

@rytismi rytismi commented Aug 23, 2024

Creating PR to see if I'm heading the right direction. Created most SQL and YAML files.

Could you please expand on how should I test the models? Struggling to find any info.

@marcosmarxm
Copy link
Member

Nice work @rytismi I made a small change and it is working for postgres and bigquery. There is a problem with Snowflake as ORDER is a reserved word. I'm going to continue the review tomorrow.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The models are working now @rytismi do you mind update the README providing the instructions? please reach me on Slack so we can work on that,

@marcosmarxm marcosmarxm changed the title Dbt Recharge: Add DBT Converter feat(source-recharge): add fivetran dbt converter Aug 29, 2024
@rytismi
Copy link
Contributor Author

rytismi commented Aug 29, 2024

Of course!

@marcosmarxm marcosmarxm merged commit bb5cd15 into airbytehq:main Aug 31, 2024
1 check failed
@topefolorunso topefolorunso linked an issue Sep 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dbt converter for Airbyte Recharge source connector
2 participants