Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Asana: Add dbt converter #53

Merged
merged 9 commits into from
Sep 3, 2024
Merged

Source Asana: Add dbt converter #53

merged 9 commits into from
Sep 3, 2024

Conversation

pangeran-bottor
Copy link
Contributor

closes #9

@pangeran-bottor pangeran-bottor changed the title Create dbt converter for Airbyte Asana source connector Source Asana: add dbt converter Aug 14, 2024
@pangeran-bottor pangeran-bottor changed the title Source Asana: add dbt converter Source Asana: Add dbt converter Aug 14, 2024
@pangeran-bottor pangeran-bottor marked this pull request as draft August 14, 2024 18:02
marcosmarxm
marcosmarxm requested changes Aug 21, 2024
View reviewed changes
connectors/source_asana/models/fivetran_converter/project.sql Outdated
Comment on lines 4 to 20
WITH tmp AS (
SELECT
t.gid as id,
t.archived,
t.created_at,
t.current_status,
t.due_date,
t.modified_at,
t.name,
JSON_QUERY(t.owner, '$.gid') as owner_id,
t.public,
JSON_QUERY(t.team, '$.gid') as team_id,
JSON_QUERY(t.workspace, '$.gid') as workspace_id,
t.notes
FROM
{{ source('source_asana', 'projects') }} t
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start @pangeran-bottor you can use Chatgpt to translate to snowflake and postgres.

@marcosmarxm
Copy link
Member

Nice @pangeran-bottor I'm gonna review tomorrow! Sorry the delay

@marcosmarxm
Copy link
Member

@pangeran-bottor it looks good, missing a couple of models.

@pangeran-bottor
Copy link
Contributor Author

Thanks for the help @marcosmarxm
Finalized this PR to be reviewed. The models already cover all Fivetran models from https://github.com/fivetran/dbt_asana_source/blob/main/models/src_asana.yml

@pangeran-bottor pangeran-bottor marked this pull request as ready for review August 27, 2024 14:46
marcosmarxm
marcosmarxm approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pangeran-bottor the model is working now :)

@marcosmarxm marcosmarxm merged commit 8d558e4 into airbytehq:main Sep 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dbt converter for Airbyte Asana source connector
2 participants
@pangeran-bottor @marcosmarxm