-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Klaviyo: added dbt converter #52
Conversation
@marcosmarxm just want to know, am I on right track? |
Looks promising, @parthiv11. I'll review your contribution tomorrow and get back to you. |
profiles' s -->person :- Transformation is performed with some nested JSON. campaigns --> campaign with some unknow columns (probably joins with email template table)
event--> events with some unknow columns
|
|
@parthiv11 let's continue without the columns and see if the model behave as expected. |
@parthiv11 I pushed some changes. I was able to run using these models. For Klaviyo there is an small problem for staging which is different from other sources. It doesn't select a table but create an union. For that reason it won't be possible to run a simple dbt run --models +source_klaviyo --target postgres # build tables used by Fivetran this is the Airbyte models
dbt run --models +klaviyo_source --target postgres # run Fivetran models Can you move from draft to ready to review? I think there only a couple of things to be done here. |
@marcosmarxm just pushed a commit , please check it out, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @parthiv11
I ran all tests manually for all 3 databases (postgres, snowflake and bigquery) It is working perfectly! Thanks @parthiv11 |
Thank you marcos, without your help I would not be able to do early
…On Wed, Aug 28, 2024, 11:41 PM Marcos Marx ***@***.***> wrote:
Merged #52 <#52> into
main.
—
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASBGDTFGGPGR6SI32FQFXXLZTYHENAVCNFSM6AAAAABMOVL7L2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGA2TAOJWGU3TSMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
closes #17