Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker check on osx incorrectly failing #23

Merged
merged 1 commit into from
May 7, 2024

Conversation

colesnodgrass
Copy link
Member

  • on osx, don't fail the docker check if the second attempt is successful
    • On osx, docker can be communicated with via /var/run/docker.sock or ~/.docker/run/docker.sock. The existing code was incorrectly failing this check if the second attempt (~/.docker/run/docker.sock) was successful.
  • fix typo in error messages - coud -> could
  • add context to docker.New call
  • call Ping on the docker client before marking the client creation as successful
    • Fix an issue where the client would be created but would fail when communicating with it at a later step. This early Ping check establishes that we can communicate with the docker daemon before we consider our client successfully created.

@colesnodgrass colesnodgrass requested review from perangel, michel-tricot and a team May 7, 2024 22:28
@colesnodgrass colesnodgrass merged commit fa460b8 into main May 7, 2024
1 check passed
@colesnodgrass colesnodgrass deleted the cole/docker-ping branch May 7, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant