fix: docker check on osx incorrectly failing #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/run/docker.sock
or~/.docker/run/docker.sock
. The existing code was incorrectly failing this check if the second attempt (~/.docker/run/docker.sock
) was successful.coud
->could
context
todocker.New
callPing
on the docker client before marking the client creation as successfulPing
check establishes that we can communicate with the docker daemon before we consider our client successfully created.