Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove hard-coded preference for docker when installing destinations #366

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix: Remove hard-coded preference for docker when installing destinations #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions airbyte/destinations/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ def get_destination(
install_if_missing: Whether to install the connector if it is not available locally. This
parameter is ignored when local_executable is set.
"""
if not pip_url and not local_executable:
# Destination connectors are not yet published to PyPI.
# Default to Docker-based execution if no other method is explicitly requested.
docker_image = docker_image or True

return Destination(
name=name,
config=config,
Expand Down
Loading