Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GDALNearblack binding #114

Merged
merged 70 commits into from
Sep 28, 2023
Merged

Add GDALNearblack binding #114

merged 70 commits into from
Sep 28, 2023

Conversation

pericles-tpt
Copy link
Contributor

  • implement GDALNearblack binding
  • implement Nearblack go function (call function)
  • add TestNearblackBlack, TestNearblackWhite and TestNearblackInvalidSwitch to test the binding

@pericles-tpt
Implement functional godalGridCreate wrapper (WIP)
59a03b0
@pericles-tpt
Add gridCreateOpts go struct
68ace26
@pericles-tpt
Implement GridCreate go function, add GriddingAlg enum
b3440ca
@pericles-tpt
Add working TestGridCreate (needs asserts)
cbf5c30
@pericles-tpt
Update godalGridCreate to support multiple gridding algs and their …
21751d1 
…params
@pericles-tpt
Update GridCreate for new godalGridCreate signature
4ebb848
@pericles-tpt
Fix GridCreate call in TestGridCreate
a8120dc
@pericles-tpt
Remove unused String() method for GriddingAlg, add `gridAlgFromSt…
5fb5963 
…ring` function
@pericles-tpt
Replace redundant gridAlgorithm param, replace with string lookup o…
93fdfc5 
…f GriddingAlg
@pericles-tpt
Finish TestGridCreate() add required test files to "testdata/"
4d7e2af
@pericles-tpt
Update go.sum
97b6247
@pericles-tpt
Remove TODOs, minor naming changes
2c6ab1b
@pericles-tpt
Replace hardcoded size properties
f46ce9c
@pericles-tpt
Create separate GDALGridParseAlgorithmAndOptions() binding
6745188
@pericles-tpt
Update GridCreate() to use new `godalGridParseAlgorithmAndOptions()…
dc22310 
…` binding
@pericles-tpt
Add setGridCreateOption
07826c4
@pericles-tpt
Add comment for GridCreate()
8fb3bc4
@pericles-tpt
Add GDAL_VERSION_NUM check to include the correct function name for…
cdb176d 
… `ParseAlgorithmAndOptions`
@pericles-tpt
Fix indentation
a06e3bc
@pericles-tpt
Make GriddingAlg a private enum
912be53
@pericles-tpt
Improve clarity of griddingAlg string -> enum conversion
7724496
@pericles-tpt
Merge functionality from godalGridParseAlgorithmAndOptions into `go…
65a90bd 
…dalGridCreate`
@pericles-tpt
Remove []byte return parameter from GridCreate
d4775b1
@pericles-tpt
Update TestGridCreate for GridCreate changes
960be8a
@pericles-tpt
Change uint32 params in GridCreate() to int
faa1c50
@pericles-tpt
Remove "grid" test files from testdata/
16ce078
@pericles-tpt
Rename setGridCreateOption() to setGridCreateOpt() (for consistency)
e478b45
@pericles-tpt
Remove unused options pointer
18bec58
@pericles-tpt
Remove redundant griddingAlg and gridAlg()
8f758d2
@pericles-tpt
Improve GridCreate tests by - testing two algorithms and justifying…
1f2c6a1 
… expected values
pericles-tpt and others added 15 commits September 14, 2023 16:48
@coveralls
Copy link
Collaborator

coveralls commented Sep 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6332749537

  • 40 of 40 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.405%
Totals Coverage Status
Change from base Build 6194915744: 0.02%
Covered Lines: 3331
Relevant Lines: 3385
💛 - Coveralls

tbonfort
tbonfort requested changes Sep 21, 2023
View reviewed changes
godal.go Outdated Show resolved Hide resolved
godal.go Outdated Show resolved Hide resolved
godal.h Outdated Show resolved Hide resolved
godal.go Outdated Show resolved Hide resolved
godal_test.go Show resolved Hide resolved
godal_test.go Show resolved Hide resolved
godal_test.go Show resolved Hide resolved
pericles-tpt and others added 6 commits September 22, 2023 10:17
@pericles-tpt @tbonfort
Update comment
4e2914f 
Co-authored-by: Thomas Bonfort <[email protected]>
@pericles-tpt @tbonfort
Update comment
07157ce 
Co-authored-by: Thomas Bonfort <[email protected]>
@pericles-tpt @tbonfort
Remove duplicate godalGrid function signature
d9ab5ba 
Co-authored-by: Thomas Bonfort <[email protected]>
@pericles-tpt @tbonfort
Add missing deferred Close()
ec2de04 
Co-authored-by: Thomas Bonfort <[email protected]>
@pericles-tpt @tbonfort
Add missing deferred Close()
b95aaee 
Co-authored-by: Thomas Bonfort <[email protected]>
@pericles-tpt
Split Nearblack into Nearblack and NearblackInto functions, add…
95b7d58 
… tests, add missing `Close()`s
tbonfort
tbonfort reviewed Sep 22, 2023
View reviewed changes
godal.go Outdated Show resolved Hide resolved
@tbonfort tbonfort merged commit 4a1ba9d into airbusgeo:main Sep 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbonfort tbonfort tbonfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pericles-tpt @coveralls @tbonfort