Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions and types to variables #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add descriptions and types to variables #167

wants to merge 1 commit into from
+64 −2

Conversation

jdheyburn
Copy link

to: @airbnb/binaryalert-maintainers
cc:
size: small
resolves #166

Background

It is a Terraform best practice to use descriptions and types for variables. This PR ensures that we respect that.

Changes

  • Descriptions and types added to Terraform variables.tf

Testing

N/A

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.52% when pulling a947245 on jdheyburn:variables_improvements into a9c0f06 on airbnb:master.

@phretor phretor mentioned this pull request Jan 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add descriptions to variables
2 participants
@jdheyburn @coveralls